Merge pull request #73 from s4u/fix-misspell

Fix misspell in test action
2026-02-13 00:05:10 +08:00 · 2024-02-11 13:37:22 +01:00 · 2024-02-11 13:26:42 +01:00 · 2024-02-11 13:00:29 +01:00 · 2024-02-11 12:49:28 +01:00 · 2024-02-11 12:38:27 +01:00
3 changed files with 13 additions and 15 deletions
--- a/.github/workflows/test.yml
+++ b/.github/workflows/test.yml
@ -19,7 +19,7 @@ jobs:
      matrix:
        os: [ 'ubuntu-latest', 'windows-latest', 'macOS-latest' ]
        java: [ '8', '11', '17', '21' ]
-        maven: [ '3.8.8', '3.9.5' ]
+        maven: [ '3.8.8', '3.9.6' ]
      fail-fast: false

    runs-on: ${{ matrix.os }}
@ -36,7 +36,7 @@ jobs:
      - run: mvn -V validate -Drequire.java=${{ matrix.java }} -Drequire.maven=${{ matrix.maven }}
        shell: bash

-  test-deault:
+  test-default:
    name: Test with defaults
    runs-on: ubuntu-latest

@ -45,20 +45,18 @@ jobs:

      - uses: ./

-      - run: mvn -V validate -Drequire.java=17 -Drequire.maven=3.9.5
+      - run: mvn -V validate -Drequire.java=17 -Drequire.maven=3.9.6
        shell: bash

  test-ok:
    name: Test OK
    runs-on: ubuntu-latest
-    needs: [ test, test-deault ]
+    needs: [ test, test-default ]
    if: always()

    steps:
-      - run: echo "needs.test.result=${{ needs.test.result }} needs.test-deault.result=${{ needs.test-deault.result }}"
-
      - run: 'true'
-        if: needs.test.result == 'success' && needs.test-deault.result == 'success'
+        if: join(needs.*.result, ',') == 'success,success'

      - run: 'false'
-        if: needs.test.result != 'success' || needs.test-deault.result != 'success'
+        if: join(needs.*.result, ',') != 'success,success'
--- a/README.md
+++ b/README.md
@ -70,7 +70,7 @@ So we can use for action:

 | params        | destination   | default |
 |---------------|---------------|---------|
-| maven-version | maven-version | 3.9.5   |
+| maven-version | maven-version | 3.9.6   |

 ## maven-settings-action

@ -91,7 +91,7 @@ jobs:

    strategy:
      matrix:
-        maven: [ '3.8.8', '3.9.5' ]
+        maven: [ '3.8.8', '3.9.6' ]

    name: Maven ${{ matrix.maven }} sample

--- a/action.yml
+++ b/action.yml
@ -69,7 +69,7 @@ inputs:
  # maven version
  maven-version:
    description: 'The Maven version to set up'
-    default: '3.9.5'
+    default: '3.9.6'
    required: false

  # maven settings.xml
@ -103,13 +103,13 @@ runs:
        repository: '${{ inputs.checkout-repository }}'
        token: '${{ inputs.checkout-token }}'

-    - uses: actions/setup-java@v3
+    - uses: actions/setup-java@v4
      with:
        overwrite-settings: false
        java-version: '${{ inputs.java-version }}'
        distribution: '${{ inputs.java-distribution }}'

-    - uses: actions/cache@v3
+    - uses: actions/cache@v4
      if: inputs.cache-enabled == 'true'
      with:
        path: |
@ -123,12 +123,12 @@ runs:
      shell: bash
      id: current-maven

-    - uses: stCarolas/setup-maven@v4.5
+    - uses: stCarolas/setup-maven@v5
      if: inputs.maven-version != steps.current-maven.outputs.version
      with:
        maven-version: '${{ inputs.maven-version }}'

-    - uses: s4u/maven-settings-action@v2.8.0
+    - uses: s4u/maven-settings-action@v3.0.0
      with:
        servers: '${{ inputs.settings-servers}}'
        mirrors: '${{ inputs.settings-mirrors}}'
Author	SHA1	Message	Date
Slawomir Jaranowski	6d44c18d67	Merge pull request #73 from s4u/fix-misspell Fix misspell in test action	2024-02-11 13:37:22 +01:00
Slawomir Jaranowski	9f3d803b4e	Fix misspell in test action	2024-02-11 13:26:42 +01:00
Slawomir Jaranowski	023b47f3ae	Merge pull request #72 from s4u/mvn396 Maven 3.9.6 as default	2024-02-11 13:00:29 +01:00
Slawomir Jaranowski	5257c30aee	Maven 3.9.6 as default	2024-02-11 12:49:28 +01:00
Slawomir Jaranowski	88b5bc7548	Merge pull request #70 from NotMyFault/update-deps-node-20 Update stCarolas/setup-maven to v5	2024-02-11 12:38:27 +01:00
dependabot[bot]	6c5362973d	Bump actions/cache from 3 to 4 Bumps [actions/cache](https://github.com/actions/cache) from 3 to 4. - [Release notes](https://github.com/actions/cache/releases) - [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md) - [Commits](https://github.com/actions/cache/compare/v3...v4) --- updated-dependencies: - dependency-name: actions/cache dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>	2024-02-11 12:30:38 +01:00
Alexander Brandes	f8353fecf3	Update stCarolas/setup-maven to v5 Signed-off-by: Alexander Brandes <mc.cache@web.de>	2024-02-11 12:22:35 +01:00
dependabot[bot]	9337884575	Bump s4u/maven-settings-action from 2.8.0 to 3.0.0 Bumps [s4u/maven-settings-action](https://github.com/s4u/maven-settings-action) from 2.8.0 to 3.0.0. - [Release notes](https://github.com/s4u/maven-settings-action/releases) - [Commits](https://github.com/s4u/maven-settings-action/compare/v2.8.0...v3.0.0) --- updated-dependencies: - dependency-name: s4u/maven-settings-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>	2024-01-01 20:49:36 +01:00
dependabot[bot]	c6cceea941	Bump actions/setup-java from 3 to 4 Bumps [actions/setup-java](https://github.com/actions/setup-java) from 3 to 4. - [Release notes](https://github.com/actions/setup-java/releases) - [Commits](https://github.com/actions/setup-java/compare/v3...v4) --- updated-dependencies: - dependency-name: actions/setup-java dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>	2024-01-01 20:45:57 +01:00